Skip to content

Fix encoding issue in encode_path method - #343

Closed
TaopaiC wants to merge 1 commit into
hashicorp:masterfrom
TaopaiC:patch/encode_path
Closed

Fix encoding issue in encode_path method#343
TaopaiC wants to merge 1 commit into
hashicorp:masterfrom
TaopaiC:patch/encode_path

Conversation

@TaopaiC

@TaopaiC TaopaiC commented Sep 13, 2024

Copy link
Copy Markdown
Contributor

Fix encode_path whitelist to exclude '-' from encoding

Fix `encode_path` whitelist to exclude '-' from encoding
@TaopaiC
TaopaiC requested a review from a team as a code owner September 13, 2024 14:23
@hashicorp-cla-app

hashicorp-cla-app Bot commented Sep 13, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ochnerd

ochnerd commented Oct 1, 2024

Copy link
Copy Markdown

@TaopaiC would you mind adding ':' to this commit too?
We use ':' in our secrets and have the same issue.

@khiav223577

Copy link
Copy Markdown

The current code escapes ~ as %7E, but should we be doing this? CGI.escape does not escape ~.

chrisarcand added a commit that referenced this pull request Feb 3, 2026
- Add unit tests for EncodePath#encode_path verifying correct
  handling of hyphens, spaces, and special characters
- Document the encode_path hyphen fix in CHANGELOG [GH-350, GH-343]
chrisarcand added a commit that referenced this pull request Feb 3, 2026
- Add unit tests for EncodePath#encode_path verifying correct
  handling of hyphens, spaces, and special characters
- Document the encode_path hyphen fix in CHANGELOG [GH-350, GH-343]
@chrisarcand chrisarcand mentioned this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants